1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
//! This table summarizes when a MLS group can create a commit or proposal:
//!
//! | can create handshake ? | 0 pend. Commit | 1 pend. Commit |
//! |------------------------|----------------|----------------|
//! | 0 pend. Proposal | ✅ | ❌ |
//! | 1+ pend. Proposal | ✅ | ❌ |
use openmls::prelude::{KeyPackageIn, LeafNode, LeafNodeIndex, MlsMessageOut};
use mls_crypto_provider::MlsCryptoProvider;
use crate::{
e2e_identity::init_certificates::NewCrlDistributionPoint,
mls::credential::{
crl::{extract_crl_uris_from_credentials, get_new_crl_distribution_points},
CredentialBundle,
},
prelude::{Client, ClientId, ConversationId, CryptoError, CryptoResult, MlsCentral, MlsError, MlsGroupInfoBundle},
};
use super::MlsConversation;
impl MlsCentral {
/// Adds new members to the group/conversation
///
/// # Arguments
/// * `id` - group/conversation id
/// * `members` - members to be added to the group
///
/// # Return type
/// An optional struct containing a welcome and a message will be returned on successful call.
/// The value will be `None` only if the group can't be found locally (no error will be returned
/// in this case).
///
/// # Errors
/// If the authorisation callback is set, an error can be caused when the authorization fails.
/// Other errors are KeyStore and OpenMls errors:
#[cfg_attr(test, crate::idempotent)]
pub async fn add_members_to_conversation(
&mut self,
id: &ConversationId,
key_packages: Vec<KeyPackageIn>,
) -> CryptoResult<MlsConversationCreationMessage> {
if let Some(callbacks) = self.callbacks.as_ref() {
let client_id = self.mls_client()?.id().clone();
if !callbacks.authorize(id.clone(), client_id).await {
return Err(CryptoError::Unauthorized);
}
}
self.get_conversation(id)
.await?
.write()
.await
.add_members(self.mls_client()?, key_packages, &self.mls_backend)
.await
}
/// Removes clients from the group/conversation.
///
/// # Arguments
/// * `id` - group/conversation id
/// * `clients` - list of client ids to be removed from the group
///
/// # Return type
/// An struct containing a welcome(optional, will be present only if there's pending add
/// proposals in the store), a message with the commit to fan out to other clients and
/// the group info will be returned on successful call.
///
/// # Errors
/// If the authorisation callback is set, an error can be caused when the authorization fails. Other errors are KeyStore and OpenMls errors.
#[cfg_attr(test, crate::idempotent)]
pub async fn remove_members_from_conversation(
&mut self,
id: &ConversationId,
clients: &[ClientId],
) -> CryptoResult<MlsCommitBundle> {
if let Some(callbacks) = self.callbacks.as_ref() {
let client_id = self.mls_client()?.id().clone();
if !callbacks.authorize(id.clone(), client_id).await {
return Err(CryptoError::Unauthorized);
}
}
self.get_conversation(id)
.await?
.write()
.await
.remove_members(self.mls_client()?, clients, &self.mls_backend)
.await
}
/// Self updates the KeyPackage and automatically commits. Pending proposals will be commited
///
/// # Arguments
/// * `conversation_id` - the group/conversation id
///
/// # Return type
/// An struct containing a welcome(optional, will be present only if there's pending add
/// proposals in the store), a message with the commit to fan out to other clients and
/// the group info will be returned on successful call.
///
/// # Errors
/// If the conversation can't be found, an error will be returned. Other errors are originating
/// from OpenMls and the KeyStore
#[cfg_attr(test, crate::idempotent)]
pub async fn update_keying_material(&mut self, id: &ConversationId) -> CryptoResult<MlsCommitBundle> {
self.get_conversation(id)
.await?
.write()
.await
.update_keying_material(self.mls_client()?, &self.mls_backend, None, None)
.await
}
/// Commits all pending proposals of the group
///
/// # Arguments
/// * `backend` - the KeyStore to persist group changes
///
/// # Return type
/// A tuple containing the commit message and a possible welcome (in the case `Add` proposals were pending within the internal MLS Group)
///
/// # Errors
/// Errors can be originating from the KeyStore and OpenMls
#[cfg_attr(test, crate::idempotent)]
pub async fn commit_pending_proposals(&mut self, id: &ConversationId) -> CryptoResult<Option<MlsCommitBundle>> {
self.get_conversation(id)
.await?
.write()
.await
.commit_pending_proposals(self.mls_client()?, &self.mls_backend)
.await
}
}
/// Creating commit
impl MlsConversation {
/// see [MlsCentral::add_members_to_conversation]
/// Note: this is not exposed publicly because authorization isn't handled at this level
#[cfg_attr(test, crate::durable)]
pub(crate) async fn add_members(
&mut self,
client: &Client,
key_packages: Vec<KeyPackageIn>,
backend: &MlsCryptoProvider,
) -> CryptoResult<MlsConversationCreationMessage> {
let signer = &self
.find_most_recent_credential_bundle(client)?
.ok_or(CryptoError::IdentityInitializationError)?
.signature_key;
// No need to also check pending proposals since they should already have been scanned while decrypting the proposal message
let crl_new_distribution_points = get_new_crl_distribution_points(
backend,
extract_crl_uris_from_credentials(key_packages.iter().filter_map(|kp| {
let mls_credential = kp.credential().mls_credential();
if matches!(mls_credential, openmls::prelude::MlsCredentialType::X509(_)) {
Some(mls_credential)
} else {
None
}
}))?,
)
.await?;
let (commit, welcome, gi) = self
.group
.add_members(backend, signer, key_packages)
.await
.map_err(MlsError::from)?;
// SAFETY: This should be safe as adding members always generates a new commit
let gi = gi.ok_or(CryptoError::ImplementationError)?;
let group_info = MlsGroupInfoBundle::try_new_full_plaintext(gi)?;
self.persist_group_when_changed(backend, false).await?;
Ok(MlsConversationCreationMessage {
welcome,
commit,
group_info,
crl_new_distribution_points,
})
}
/// see [MlsCentral::remove_members_from_conversation]
/// Note: this is not exposed publicly because authorization isn't handled at this level
#[cfg_attr(test, crate::durable)]
pub(crate) async fn remove_members(
&mut self,
client: &Client,
clients: &[ClientId],
backend: &MlsCryptoProvider,
) -> CryptoResult<MlsCommitBundle> {
let member_kps = self
.group
.members()
.filter(|kp| {
clients
.iter()
.any(move |client_id| client_id.as_slice() == kp.credential.identity())
})
.try_fold(vec![], |mut acc, kp| -> CryptoResult<Vec<LeafNodeIndex>> {
acc.push(kp.index);
Ok(acc)
})?;
let signer = &self
.find_most_recent_credential_bundle(client)?
.ok_or(CryptoError::IdentityInitializationError)?
.signature_key;
let (commit, welcome, gi) = self
.group
.remove_members(backend, signer, &member_kps)
.await
.map_err(MlsError::from)?;
// SAFETY: This should be safe as removing members always generates a new commit
let gi = gi.ok_or(CryptoError::ImplementationError)?;
let group_info = MlsGroupInfoBundle::try_new_full_plaintext(gi)?;
self.persist_group_when_changed(backend, false).await?;
Ok(MlsCommitBundle {
commit,
welcome,
group_info,
})
}
/// see [MlsCentral::update_keying_material]
#[cfg_attr(test, crate::durable)]
pub(crate) async fn update_keying_material(
&mut self,
client: &Client,
backend: &MlsCryptoProvider,
cb: Option<&CredentialBundle>,
leaf_node: Option<LeafNode>,
) -> CryptoResult<MlsCommitBundle> {
let cb = cb
.or_else(|| self.find_most_recent_credential_bundle(client).ok().flatten())
.ok_or(CryptoError::IdentityInitializationError)?;
let (commit, welcome, group_info) = self
.group
.explicit_self_update(backend, &cb.signature_key, leaf_node)
.await
.map_err(MlsError::from)?;
// We should always have ratchet tree extension turned on hence GroupInfo should always be present
let group_info = group_info.ok_or(CryptoError::ImplementationError)?;
let group_info = MlsGroupInfoBundle::try_new_full_plaintext(group_info)?;
self.persist_group_when_changed(backend, false).await?;
Ok(MlsCommitBundle {
welcome,
commit,
group_info,
})
}
/// see [MlsCentral::commit_pending_proposals]
#[cfg_attr(test, crate::durable)]
pub(crate) async fn commit_pending_proposals(
&mut self,
client: &Client,
backend: &MlsCryptoProvider,
) -> CryptoResult<Option<MlsCommitBundle>> {
if self.group.pending_proposals().count() > 0 {
let signer = &self
.find_most_recent_credential_bundle(client)?
.ok_or(CryptoError::IdentityInitializationError)?
.signature_key;
let (commit, welcome, gi) = self
.group
.commit_to_pending_proposals(backend, signer)
.await
.map_err(MlsError::from)?;
let group_info = MlsGroupInfoBundle::try_new_full_plaintext(gi.unwrap())?;
self.persist_group_when_changed(backend, false).await?;
Ok(Some(MlsCommitBundle {
welcome,
commit,
group_info,
}))
} else {
Ok(None)
}
}
}
/// Returned when initializing a conversation through a commit.
/// Different from conversation created from a [`openmls::prelude::Welcome`] message or an external commit.
#[derive(Debug)]
pub struct MlsConversationCreationMessage {
/// A welcome message for new members to join the group
pub welcome: MlsMessageOut,
/// Commit message adding members to the group
pub commit: MlsMessageOut,
/// `GroupInfo` if the commit is merged
pub group_info: MlsGroupInfoBundle,
/// New CRL distribution points that appeared by the introduction of a new credential
pub crl_new_distribution_points: NewCrlDistributionPoint,
}
impl MlsConversationCreationMessage {
/// Serializes both wrapped objects into TLS and return them as a tuple of byte arrays.
/// 0 -> welcome
/// 1 -> commit
/// 2 -> group_info
#[allow(clippy::type_complexity)]
pub fn to_bytes(self) -> CryptoResult<(Vec<u8>, Vec<u8>, MlsGroupInfoBundle, NewCrlDistributionPoint)> {
use openmls::prelude::TlsSerializeTrait as _;
let welcome = self.welcome.tls_serialize_detached().map_err(MlsError::from)?;
let msg = self.commit.tls_serialize_detached().map_err(MlsError::from)?;
Ok((welcome, msg, self.group_info, self.crl_new_distribution_points))
}
}
/// Returned when a commit is created
#[derive(Debug, Clone)]
pub struct MlsCommitBundle {
/// A welcome message if there are pending Add proposals
pub welcome: Option<MlsMessageOut>,
/// The commit message
pub commit: MlsMessageOut,
/// `GroupInfo` if the commit is merged
pub group_info: MlsGroupInfoBundle,
}
impl MlsCommitBundle {
/// Serializes both wrapped objects into TLS and return them as a tuple of byte arrays.
/// 0 -> welcome
/// 1 -> message
/// 2 -> public group state
#[allow(clippy::type_complexity)]
pub fn to_bytes_triple(self) -> CryptoResult<(Option<Vec<u8>>, Vec<u8>, MlsGroupInfoBundle)> {
use openmls::prelude::TlsSerializeTrait as _;
let welcome = self
.welcome
.as_ref()
.map(|w| w.tls_serialize_detached().map_err(MlsError::from))
.transpose()?;
let commit = self.commit.tls_serialize_detached().map_err(MlsError::from)?;
Ok((welcome, commit, self.group_info))
}
}
#[cfg(test)]
mod tests {
use itertools::Itertools;
use openmls::prelude::SignaturePublicKey;
use wasm_bindgen_test::*;
use crate::test_utils::*;
use super::*;
wasm_bindgen_test_configure!(run_in_browser);
mod add_members {
use super::*;
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn can_add_members_to_conversation(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
let bob = bob_central.mls_central.rand_key_package(&case).await;
let MlsConversationCreationMessage { welcome, .. } = alice_central
.mls_central
.add_members_to_conversation(&id, vec![bob])
.await
.unwrap();
// before merging, commit is not applied
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
1
);
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert_eq!(alice_central.mls_central.get_conversation_unchecked(&id).await.id, id);
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.group
.group_id()
.as_slice(),
id
);
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
bob_central
.mls_central
.process_welcome_message(welcome.into(), case.custom_cfg())
.await
.unwrap();
assert_eq!(
alice_central.mls_central.get_conversation_unchecked(&id).await.id(),
bob_central.mls_central.get_conversation_unchecked(&id).await.id()
);
assert_eq!(
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
})
},
)
.await
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_welcome(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
let bob = bob_central.mls_central.rand_key_package(&case).await;
let welcome = alice_central
.mls_central
.add_members_to_conversation(&id, vec![bob])
.await
.unwrap()
.welcome;
alice_central.mls_central.commit_accepted(&id).await.unwrap();
bob_central
.mls_central
.process_welcome_message(welcome.into(), case.custom_cfg())
.await
.unwrap();
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
})
},
)
.await
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_group_info(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
let bob = bob_central.mls_central.rand_key_package(&case).await;
let commit_bundle = alice_central
.mls_central
.add_members_to_conversation(&id, vec![bob])
.await
.unwrap();
let group_info = commit_bundle.group_info.get_group_info();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(guest_central
.mls_central
.try_join_from_group_info(&case, &id, group_info, vec![&mut alice_central.mls_central])
.await
.is_ok());
})
},
)
.await
}
}
mod remove_members {
use super::*;
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn alice_can_remove_bob_from_conversation(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let MlsCommitBundle { commit, welcome, .. } = alice_central
.mls_central
.remove_members_from_conversation(&id, &[bob_central.mls_central.get_client_id()])
.await
.unwrap();
assert!(welcome.is_none());
// before merging, commit is not applied
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
1
);
bob_central
.mls_central
.decrypt_message(&id, commit.to_bytes().unwrap())
.await
.unwrap();
// But has been removed from the conversation
assert!(matches!(
bob_central.mls_central.get_conversation(&id).await.unwrap_err(),
CryptoError::ConversationNotFound(conv_id) if conv_id == id
));
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_err());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_welcome(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, mut bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let proposal = alice_central
.mls_central
.new_add_proposal(&id, guest_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap();
bob_central
.mls_central
.decrypt_message(&id, proposal.proposal.to_bytes().unwrap())
.await
.unwrap();
let welcome = alice_central
.mls_central
.remove_members_from_conversation(&id, &[bob_central.mls_central.get_client_id()])
.await
.unwrap()
.welcome;
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(guest_central
.mls_central
.try_join_from_welcome(
&id,
welcome.unwrap().into(),
case.custom_cfg(),
vec![&mut alice_central.mls_central]
)
.await
.is_ok());
// because Bob has been removed from the group
assert!(guest_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_err());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_group_info(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, mut bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let commit_bundle = alice_central
.mls_central
.remove_members_from_conversation(&id, &[bob_central.mls_central.get_client_id()])
.await
.unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
let group_info = commit_bundle.group_info.get_group_info();
assert!(guest_central
.mls_central
.try_join_from_group_info(&case, &id, group_info, vec![&mut alice_central.mls_central])
.await
.is_ok());
// because Bob has been removed from the group
assert!(guest_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_err());
})
},
)
.await;
}
}
mod update_keying_material {
use super::*;
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_succeed(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let init_count = alice_central.mls_central.count_entities().await;
let bob_keys = bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<Vec<u8>>>();
let alice_keys = alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<Vec<u8>>>();
assert!(alice_keys.iter().all(|a_key| bob_keys.contains(a_key)));
let alice_key = alice_central
.mls_central
.encryption_key_of(&id, alice_central.mls_central.get_client_id())
.await;
// proposing the key update for alice
let MlsCommitBundle { commit, welcome, .. } =
alice_central.mls_central.update_keying_material(&id).await.unwrap();
assert!(welcome.is_none());
// before merging, commit is not applied
assert!(alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.contains(&alice_key));
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(!alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.contains(&alice_key));
let alice_new_keys = alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<_>>();
assert!(!alice_new_keys.contains(&alice_key));
// receiving the commit on bob's side (updating key from alice)
bob_central
.mls_central
.decrypt_message(&id, &commit.to_bytes().unwrap())
.await
.unwrap();
let bob_new_keys = bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<_>>();
assert!(alice_new_keys.iter().all(|a_key| bob_new_keys.contains(a_key)));
// ensuring both can encrypt messages
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
// make sure inline update commit + merge does not leak anything
// that's obvious since no new encryption keypair is created in this case
let final_count = alice_central.mls_central.count_entities().await;
assert_eq!(init_count, final_count);
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_create_welcome_for_pending_add_proposals(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "charlie"],
move |[mut alice_central, mut bob_central, mut charlie_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let bob_keys = bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.signature_keys()
.collect::<Vec<SignaturePublicKey>>();
let alice_keys = alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.signature_keys()
.collect::<Vec<SignaturePublicKey>>();
// checking that the members on both sides are the same
assert!(alice_keys.iter().all(|a_key| bob_keys.contains(a_key)));
let alice_key = alice_central
.mls_central
.encryption_key_of(&id, alice_central.mls_central.get_client_id())
.await;
// proposing adding charlie
let charlie_kp = charlie_central.mls_central.get_one_key_package(&case).await;
let add_charlie_proposal = alice_central
.mls_central
.new_add_proposal(&id, charlie_kp)
.await
.unwrap();
// receiving the proposal on Bob's side
bob_central
.mls_central
.decrypt_message(&id, add_charlie_proposal.proposal.to_bytes().unwrap())
.await
.unwrap();
// performing an update on Alice's key. this should generate a welcome for Charlie
let MlsCommitBundle { commit, welcome, .. } =
alice_central.mls_central.update_keying_material(&id).await.unwrap();
assert!(welcome.is_some());
assert!(alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.contains(&alice_key));
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(!alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.contains(&alice_key));
// create the group on charlie's side
charlie_central
.mls_central
.process_welcome_message(welcome.unwrap().into(), case.custom_cfg())
.await
.unwrap();
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
3
);
assert_eq!(
charlie_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
3
);
// bob still didn't receive the message with the updated key and charlie's addition
assert_eq!(
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
let alice_new_keys = alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<Vec<u8>>>();
assert!(!alice_new_keys.contains(&alice_key));
// receiving the key update and the charlie's addition to the group
bob_central
.mls_central
.decrypt_message(&id, &commit.to_bytes().unwrap())
.await
.unwrap();
assert_eq!(
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
3
);
let bob_new_keys = bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.encryption_keys()
.collect::<Vec<Vec<u8>>>();
assert!(alice_new_keys.iter().all(|a_key| bob_new_keys.contains(a_key)));
// ensure all parties can encrypt messages
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
assert!(bob_central
.mls_central
.try_talk_to(&id, &mut charlie_central.mls_central)
.await
.is_ok());
assert!(charlie_central
.mls_central
.try_talk_to(&id, &mut alice_central.mls_central)
.await
.is_ok());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_welcome(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, mut bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let proposal = alice_central
.mls_central
.new_add_proposal(&id, guest_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap()
.proposal;
bob_central
.mls_central
.decrypt_message(&id, proposal.to_bytes().unwrap())
.await
.unwrap();
let MlsCommitBundle { commit, welcome, .. } =
alice_central.mls_central.update_keying_material(&id).await.unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
bob_central
.mls_central
.decrypt_message(&id, commit.to_bytes().unwrap())
.await
.unwrap();
assert!(guest_central
.mls_central
.try_join_from_welcome(
&id,
welcome.unwrap().into(),
case.custom_cfg(),
vec![&mut alice_central.mls_central, &mut bob_central.mls_central]
)
.await
.is_ok());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_group_info(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, mut bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let commit_bundle = alice_central.mls_central.update_keying_material(&id).await.unwrap();
let group_info = commit_bundle.group_info.get_group_info();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(guest_central
.mls_central
.try_join_from_group_info(&case, &id, group_info, vec![&mut alice_central.mls_central])
.await
.is_ok());
})
},
)
.await;
}
}
mod commit_pending_proposals {
use super::*;
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_create_a_commit_out_of_self_pending_proposals(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.new_add_proposal(&id, bob_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap();
assert!(!alice_central.mls_central.pending_proposals(&id).await.is_empty());
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
1
);
let MlsCommitBundle { welcome, .. } = alice_central
.mls_central
.commit_pending_proposals(&id)
.await
.unwrap()
.unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
bob_central
.mls_central
.process_welcome_message(welcome.unwrap().into(), case.custom_cfg())
.await
.unwrap();
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_none_when_there_are_no_pending_proposals(case: TestCase) {
run_test_with_client_ids(case.clone(), ["alice"], move |[mut alice_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
assert!(alice_central.mls_central.pending_proposals(&id).await.is_empty());
assert!(alice_central
.mls_central
.commit_pending_proposals(&id)
.await
.unwrap()
.is_none());
})
})
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_create_a_commit_out_of_pending_proposals_by_ref(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "charlie"],
move |[mut alice_central, mut bob_central, charlie_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let proposal = bob_central
.mls_central
.new_add_proposal(&id, charlie_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap();
assert!(!bob_central.mls_central.pending_proposals(&id).await.is_empty());
assert_eq!(
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
2
);
alice_central
.mls_central
.decrypt_message(&id, proposal.proposal.to_bytes().unwrap())
.await
.unwrap();
let MlsCommitBundle { commit, .. } = alice_central
.mls_central
.commit_pending_proposals(&id)
.await
.unwrap()
.unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert_eq!(
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
3
);
bob_central
.mls_central
.decrypt_message(&id, commit.to_bytes().unwrap())
.await
.unwrap();
assert_eq!(
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.members()
.len(),
3
);
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_welcome(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.new_add_proposal(&id, bob_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap();
let MlsCommitBundle { welcome, .. } = alice_central
.mls_central
.commit_pending_proposals(&id)
.await
.unwrap()
.unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
bob_central
.mls_central
.process_welcome_message(welcome.unwrap().into(), case.custom_cfg())
.await
.unwrap();
assert!(alice_central
.mls_central
.try_talk_to(&id, &mut bob_central.mls_central)
.await
.is_ok());
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_return_valid_group_info(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob", "guest"],
move |[mut alice_central, bob_central, mut guest_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.new_add_proposal(&id, bob_central.mls_central.get_one_key_package(&case).await)
.await
.unwrap();
let commit_bundle = alice_central
.mls_central
.commit_pending_proposals(&id)
.await
.unwrap()
.unwrap();
let group_info = commit_bundle.group_info.get_group_info();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
assert!(guest_central
.mls_central
.try_join_from_group_info(&case, &id, group_info, vec![&mut alice_central.mls_central])
.await
.is_ok());
})
},
)
.await;
}
}
mod delivery_semantics {
use crate::prelude::MlsWirePolicy;
use super::*;
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_prevent_out_of_order_commits(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let commit1 = alice_central
.mls_central
.update_keying_material(&id)
.await
.unwrap()
.commit;
let commit1 = commit1.to_bytes().unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
let commit2 = alice_central
.mls_central
.update_keying_material(&id)
.await
.unwrap()
.commit;
let commit2 = commit2.to_bytes().unwrap();
alice_central.mls_central.commit_accepted(&id).await.unwrap();
// fails when a commit is skipped
let out_of_order = bob_central.mls_central.decrypt_message(&id, &commit2).await;
assert!(matches!(out_of_order.unwrap_err(), CryptoError::BufferedFutureMessage));
// works in the right order though
// NB: here 'commit2' has been buffered so it is also applied when we decrypt commit1
bob_central.mls_central.decrypt_message(&id, &commit1).await.unwrap();
// and then fails again when trying to decrypt a commit with an epoch in the past
let past_commit = bob_central.mls_central.decrypt_message(&id, &commit1).await;
assert!(matches!(past_commit.unwrap_err(), CryptoError::StaleCommit));
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_allow_dropped_commits(case: TestCase) {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let _alice_commit = alice_central
.mls_central
.update_keying_material(&id)
.await
.unwrap()
.commit;
let bob_commit = bob_central
.mls_central
.update_keying_material(&id)
.await
.unwrap()
.commit;
// Bob commit arrives first and has precedence hence Alice's commit is dropped
alice_central
.mls_central
.decrypt_message(&id, bob_commit.to_bytes().unwrap())
.await
.unwrap();
bob_central.mls_central.commit_accepted(&id).await.unwrap();
})
},
)
.await;
}
#[apply(all_cred_cipher)]
#[wasm_bindgen_test]
async fn should_prevent_replayed_encrypted_handshake_messages(case: TestCase) {
if case.custom_cfg().wire_policy == MlsWirePolicy::Ciphertext {
run_test_with_client_ids(
case.clone(),
["alice", "bob"],
move |[mut alice_central, mut bob_central]| {
Box::pin(async move {
let id = conversation_id();
alice_central
.mls_central
.new_conversation(&id, case.credential_type, case.cfg.clone())
.await
.unwrap();
alice_central
.mls_central
.invite_all(&case, &id, [&mut bob_central.mls_central])
.await
.unwrap();
let proposal1 = alice_central
.mls_central
.new_update_proposal(&id)
.await
.unwrap()
.proposal;
let proposal2 = proposal1.clone();
alice_central
.mls_central
.get_conversation_unchecked(&id)
.await
.group
.clear_pending_proposals();
let commit1 = alice_central
.mls_central
.update_keying_material(&id)
.await
.unwrap()
.commit;
let commit2 = commit1.clone();
// replayed encrypted proposal should fail
bob_central
.mls_central
.decrypt_message(&id, proposal1.to_bytes().unwrap())
.await
.unwrap();
assert!(matches!(
bob_central
.mls_central
.decrypt_message(&id, proposal2.to_bytes().unwrap())
.await
.unwrap_err(),
CryptoError::DuplicateMessage
));
bob_central
.mls_central
.get_conversation_unchecked(&id)
.await
.group
.clear_pending_proposals();
// replayed encrypted commit should fail
bob_central
.mls_central
.decrypt_message(&id, commit1.to_bytes().unwrap())
.await
.unwrap();
assert!(matches!(
bob_central
.mls_central
.decrypt_message(&id, commit2.to_bytes().unwrap())
.await
.unwrap_err(),
CryptoError::StaleCommit
));
})
},
)
.await;
}
}
}
}