core_crypto/mls/conversation/
leaf_node_validation.rs

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
//! cf <https://www.rfc-editor.org/rfc/rfc9420.html#name-leaf-node-validation>

#[cfg(test)]
mod tests {
    use openmls::prelude::Lifetime;
    use wasm_bindgen_test::*;

    use crate::{MlsErrorKind, test_utils::*};

    use openmls::prelude::{AddMembersError, KeyPackageVerifyError};

    wasm_bindgen_test_configure!(run_in_browser);

    mod stages {

        use super::*;

        /// The validity of a LeafNode needs to be verified at the following stages:
        /// When a LeafNode is downloaded in a KeyPackage, before it is used to add the client to the group
        #[apply(all_cred_cipher)]
        #[wasm_bindgen_test]
        async fn should_validate_leaf_node_when_adding(case: TestCase) {
            run_test_with_client_ids(
                case.clone(),
                ["alice", "bob"],
                move |[mut alice_central, bob_central]| {
                    Box::pin(async move {
                        let expiration_time = 14;
                        let start = web_time::Instant::now();
                        let id = conversation_id();
                        alice_central
                            .context
                            .new_conversation(&id, case.credential_type, case.cfg.clone())
                            .await
                            .unwrap();

                        // should fail when creating Add proposal
                        let invalid_kp = bob_central.new_keypackage(&case, Lifetime::new(expiration_time)).await;

                        // Give time to the KeyPackage to expire
                        let expiration_time = core::time::Duration::from_secs(expiration_time);
                        let elapsed = start.elapsed();
                        if expiration_time > elapsed {
                            async_std::task::sleep(expiration_time - elapsed + core::time::Duration::from_secs(1))
                                .await;
                        }

                        let proposal_creation = alice_central.context.new_add_proposal(&id, invalid_kp).await;
                        let error = proposal_creation.unwrap_err();
                        assert!(innermost_source_matches!(
                            error,
                            MlsErrorKind::ProposeAddMemberError(
                                openmls::prelude::ProposeAddMemberError::KeyPackageVerifyError(
                                    KeyPackageVerifyError::InvalidLeafNode(_)
                                )
                            ),
                        ));
                        assert!(alice_central.pending_proposals(&id).await.is_empty());

                        // should fail when creating Add commits
                        let expiration_time = 14;
                        let start = web_time::Instant::now();

                        let invalid_kp = bob_central.new_keypackage(&case, Lifetime::new(expiration_time)).await;

                        // Give time to the KeyPackage to expire
                        let expiration_time = core::time::Duration::from_secs(expiration_time);
                        let elapsed = start.elapsed();
                        if expiration_time > elapsed {
                            async_std::task::sleep(expiration_time - elapsed + core::time::Duration::from_secs(1))
                                .await;
                        }

                        let commit_creation = alice_central
                            .context
                            .conversation(&id)
                            .await
                            .unwrap()
                            .add_members(vec![invalid_kp.into()])
                            .await;

                        let error = commit_creation.unwrap_err();
                        assert!(innermost_source_matches!(
                            error,
                            MlsErrorKind::MlsAddMembersError(AddMembersError::KeyPackageVerifyError(
                                KeyPackageVerifyError::InvalidLeafNode(_)
                            )),
                        ));
                        assert!(alice_central.pending_proposals(&id).await.is_empty());
                        assert!(alice_central.pending_commit(&id).await.is_none());
                    })
                },
            )
            .await
        }

        /// The validity of a LeafNode needs to be verified at the following stages:
        /// When a LeafNode is received by a group member in an Add, Update, or Commit message
        #[apply(all_cred_cipher)]
        #[wasm_bindgen_test]
        async fn should_validate_leaf_node_when_receiving_expired_add_proposal(case: TestCase) {
            run_test_with_client_ids(
                case.clone(),
                ["alice", "bob", "charlie"],
                move |[alice_central, bob_central, charlie_central]| {
                    Box::pin(async move {
                        let expiration_time = 14;
                        let start = web_time::Instant::now();
                        let id = conversation_id();
                        alice_central
                            .context
                            .new_conversation(&id, case.credential_type, case.cfg.clone())
                            .await
                            .unwrap();
                        alice_central.invite_all(&case, &id, [&bob_central]).await.unwrap();

                        let invalid_kp = charlie_central
                            .new_keypackage(&case, Lifetime::new(expiration_time))
                            .await;

                        let proposal = alice_central.context.new_add_proposal(&id, invalid_kp).await.unwrap();
                        let proposal = proposal.proposal.to_bytes().unwrap();

                        let elapsed = start.elapsed();
                        // Give time to the certificate to expire
                        let expiration_time = core::time::Duration::from_secs(expiration_time);
                        if expiration_time > elapsed {
                            async_std::task::sleep(expiration_time - elapsed + core::time::Duration::from_secs(1))
                                .await;
                        }

                        let decrypting = bob_central
                            .context
                            .conversation(&id)
                            .await
                            .unwrap()
                            .decrypt_message(proposal)
                            .await;

                        // TODO: currently succeeds as we don't anymore validate KeyPackage lifetime upon reception: find another way to craft an invalid KeyPackage. Tracking issue number: WPB-9623
                        decrypting.unwrap();
                        /*assert!(matches!(
                            decrypting.unwrap_err(),
                            CryptoError::MlsError(MlsError::MlsMessageError(ProcessMessageError::ValidationError(
                                ValidationError::KeyPackageVerifyError(KeyPackageVerifyError::InvalidLeafNode(
                                    LeafNodeValidationError::Lifetime(_)
                                ))
                            )))
                        ));*/
                    })
                },
            )
            .await
        }

        /// The validity of a LeafNode needs to be verified at the following stages:
        /// When a LeafNode is received by a group member in an Add, Update, or Commit message
        #[apply(all_cred_cipher)]
        #[wasm_bindgen_test]
        async fn should_validate_leaf_node_when_receiving_add_commit(case: TestCase) {
            run_test_with_client_ids(
                case.clone(),
                ["alice", "bob", "charlie"],
                move |[alice_central, bob_central, charlie_central]| {
                    Box::pin(async move {
                        let expiration_time = 14;
                        let start = web_time::Instant::now();
                        let id = conversation_id();
                        alice_central
                            .context
                            .new_conversation(&id, case.credential_type, case.cfg.clone())
                            .await
                            .unwrap();
                        alice_central.invite_all(&case, &id, [&bob_central]).await.unwrap();

                        // should fail when receiving Add commit
                        let invalid_kp = charlie_central
                            .new_keypackage(&case, Lifetime::new(expiration_time))
                            .await;

                        alice_central
                            .context
                            .conversation(&id)
                            .await
                            .unwrap()
                            .add_members(vec![invalid_kp.into()])
                            .await
                            .unwrap();
                        let commit = alice_central.mls_transport.latest_commit().await;
                        let commit = commit.to_bytes().unwrap();

                        let elapsed = start.elapsed();
                        // Give time to the certificate to expire
                        let expiration_time = core::time::Duration::from_secs(expiration_time);
                        if expiration_time > elapsed {
                            async_std::task::sleep(expiration_time - elapsed + core::time::Duration::from_secs(1))
                                .await;
                        }

                        let decrypting = bob_central
                            .context
                            .conversation(&id)
                            .await
                            .unwrap()
                            .decrypt_message(commit)
                            .await;

                        // TODO: currently succeeds as we don't anymore validate KeyPackage lifetime upon reception: find another way to craft an invalid KeyPackage. Tracking issue number: WPB-9623
                        decrypting.unwrap();
                        /*assert!(matches!(
                            decrypting.unwrap_err(),
                            CryptoError::MlsError(MlsError::MlsMessageError(ProcessMessageError::ValidationError(
                                ValidationError::KeyPackageVerifyError(KeyPackageVerifyError::InvalidLeafNode(_))
                            )))
                        ));*/
                    })
                },
            )
            .await
        }

        /// The validity of a LeafNode needs to be verified at the following stages:
        /// When a client validates a ratchet tree, e.g., when joining a group or after processing a Commit
        #[apply(all_cred_cipher)]
        #[wasm_bindgen_test]
        async fn should_validate_leaf_node_when_receiving_welcome(case: TestCase) {
            run_test_with_client_ids(case.clone(), ["alice", "bob"], move |[alice_central, bob_central]| {
                Box::pin(async move {
                    let expiration_time = 14;
                    let start = web_time::Instant::now();
                    let id = conversation_id();
                    alice_central
                        .context
                        .new_conversation(&id, case.credential_type, case.cfg.clone())
                        .await
                        .unwrap();

                    let invalid_kp = bob_central.new_keypackage(&case, Lifetime::new(expiration_time)).await;
                    alice_central
                        .context
                        .conversation(&id)
                        .await
                        .unwrap()
                        .add_members(vec![invalid_kp.into()])
                        .await
                        .unwrap();

                    let elapsed = start.elapsed();
                    // Give time to the certificate to expire
                    let expiration_time = core::time::Duration::from_secs(expiration_time);
                    if expiration_time > elapsed {
                        async_std::task::sleep(expiration_time - elapsed + core::time::Duration::from_secs(1)).await;
                    }

                    let process_welcome = bob_central
                        .context
                        .process_welcome_message(
                            alice_central.mls_transport.latest_welcome_message().await.into(),
                            case.custom_cfg(),
                        )
                        .await;

                    // TODO: currently succeeds as we don't anymore validate KeyPackage lifetime upon reception: find another way to craft an invalid KeyPackage. Tracking issue number: WPB-9623
                    process_welcome.unwrap();
                    /*assert!(matches!(
                        process_welcome.unwrap_err(),
                        CryptoError::MlsError(MlsError::MlsWelcomeError(WelcomeError::PublicGroupError(
                            CreationFromExternalError::TreeSyncError(
                                TreeSyncFromNodesError::LeafNodeValidationError(LeafNodeValidationError::Lifetime(
                                    _
                                ))
                            )
                        )))
                    ));*/
                })
            })
            .await
        }
    }
}